Re: Minor performance improvements - Mailing list pgsql-jdbc

From Nelson Arape
Subject Re: Minor performance improvements
Date
Msg-id 200702270942.04388.narape@ica.luz.ve
Whole thread Raw
In response to Re: Minor performance improvements  (Kris Jurka <books@ejurka.com>)
Responses Re: Minor performance improvements
List pgsql-jdbc
Hi Kris

I think that your patch could be better if instead of using the "signed" right
shift operator (>>) followed by a bit mask, use directly the "unsigned" right
shift operator (>>>)

So
((val >> 24) & 0xFF)
would better as
val >>> 24

By the way great work folks

Nelson Arapé
A happy Postgres JDBC user in his first time post to the list

PS: Sorry for my english, not my native language

El Martes, 27 de Febrero de 2007 04:21, Kris Jurka escribió:
> On Mon, 26 Feb 2007, Kris Jurka wrote:
> > I've created the attached test which tests the original code (Orig), your
> > code (Two), and my suggestion of an int4buf (Three) and got the following
> > surprising results:
>
> Based on that test and a similar attached test for reading, I'm prepared
> to apply the attached patch.  Let me know what you think.
>
> Kris Jurka

pgsql-jdbc by date:

Previous
From: Mario Splivalo
Date:
Subject: Re: Calling functions with table-based-type parametars
Next
From: "Stephen Denne"
Date:
Subject: Re: Minor performance improvements