pgsql: Now that plans have flat rangetable lists, it's a lot easier to - Mailing list pgsql-committers

Log Message:
-----------
Now that plans have flat rangetable lists, it's a lot easier to get EXPLAIN to
drill down into subplan targetlists to print the referent expression for an
OUTER or INNER var in an upper plan node.  Hence, make it do that always, and
banish the old hack of showing "?columnN?" when things got too complicated.

Along the way, fix an EXPLAIN bug I introduced by suppressing subqueries from
execution-time range tables: get_name_for_var_field() assumed it could look at
rte->subquery to find out the real type of a RECORD var.  That doesn't work
anymore, but instead we can look at the input plan of the SubqueryScan plan
node.

Modified Files:
--------------
    pgsql/src/backend/commands:
        explain.c (r1.158 -> r1.159)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/explain.c.diff?r1=1.158&r2=1.159)
    pgsql/src/backend/optimizer/plan:
        setrefs.c (r1.132 -> r1.133)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/setrefs.c.diff?r1=1.132&r2=1.133)
    pgsql/src/backend/utils/adt:
        ruleutils.c (r1.250 -> r1.251)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/ruleutils.c.diff?r1=1.250&r2=1.251)
    pgsql/src/include/utils:
        builtins.h (r1.288 -> r1.289)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/builtins.h.diff?r1=1.288&r2=1.289)