Re: XML changes broke assert-enabled vcbuild - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: XML changes broke assert-enabled vcbuild
Date
Msg-id 200702131723.57106.peter_e@gmx.net
Whole thread Raw
In response to Re: XML changes broke assert-enabled vcbuild  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: XML changes broke assert-enabled vcbuild  (Magnus Hagander <magnus@hagander.net>)
Re: XML changes broke assert-enabled vcbuild  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
> > From what I can tell, this is because the Assert() puts code (the
> > do {} loop) *before* the declaration of StringInfoData buf, which
> > is not permitted.
>
> This will fail on every ANSI-C compiler, not just vc.  Please fix.

We seem to have very poor coverage of such compilers in the build farm, 
it seems.  Is the vcbuild ready to support a regular build farm run 
yet?

It turns out that gcc warns about it anyway.  Does anyone have some sort 
of clever recipe to catch warnings more easily than by carefully 
reading the make output or manually grepping build log files or 
something?

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/


pgsql-hackers by date:

Previous
From: Marc Munro
Date:
Subject: Re: Reducing likelihood of deadlocks (was referential Integrity and SHARE locks)
Next
From: Tom Lane
Date:
Subject: Re: Variable length varlena headers redux