Re: [HACKERS] Win32 WEXITSTATUS too - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] Win32 WEXITSTATUS too
Date
Msg-id 200701221852.l0MIqBJ04773@momjian.us
Whole thread Raw
In response to Re: [HACKERS] Win32 WEXITSTATUS too  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-patches
Alvaro Herrera wrote:
> Bruce Momjian wrote:
> >
> > I have applied a modified version of this patch.  We now print the
> > exception value in hex, and give a URL where the exception can be looked
> > up.
>
> Humm, wouldn't it be more appropriate to put the URL in a errhint()
> instead?
>
> > +         ereport(lev,
> > +
> > +         /*------
> > +           translator: %s is a noun phrase describing a child process, such as
> > +           "server process" */
> > +                 (errmsg("%s (PID %d) was terminated by exception %X\nSee
http://source.winehq.org/source/include/ntstatus.hfor a description\nof the hex value.", 
> > +                         procname, pid, WTERMSIG(exitstatus))));
> > + #endif

Oops, forgot to mention that detail.  We are using log_error() in one
case, and ereport() in another.  Let me do the hint in the report case,
but I have to leave the log_error case alone because it takes only three
arguments.

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Win32 WEXITSTATUS too
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Win32 WEXITSTATUS too