Re: [HACKERS] [PATCHES] [BUGS] BUG #2846: inconsistent and - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] [PATCHES] [BUGS] BUG #2846: inconsistent and
Date
Msg-id 200701191356.l0JDumS04847@momjian.us
Whole thread Raw
List pgsql-patches
Roman Kononov wrote:
> On 12/27/2006 01:15 PM, Tom Lane wrote:
> > I'm not convinced that you're fixing things so much as doing your best
> > to destroy IEEE-compliant float arithmetic behavior.
> >
> > I think what we should probably consider is removing CheckFloat4Val
> > and CheckFloat8Val altogether, and just letting the float arithmetic
> > have its head.  Most modern hardware gets float arithmetic right per
> > spec, and we shouldn't be second-guessing it.
>
> I vote for complete IEEE-compliance. No exceptions with pure floating
> point math. Float -> int conversions should reject overflow, INF and
> NaN. Float -> numeric conversions should reject INF.

I think we did that in current CVS.  Feel free to download a snapshot
from the ftp server and try it out.

> > A slightly less radical proposal is to reject only the case where
> > isinf(result) and neither input isinf(); and perhaps likewise with
> > respect to NaNs.
>
> This might look like another possibility for confusion. For example
> INF-INF=NaN.

Yep, that's what we get now.

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Gevik Babakhani
Date:
Subject: guid/uuid datatype
Next
From: Alvaro Herrera
Date:
Subject: Re: partial pg_regress patch from Magnus