partial pg_regress patch from Magnus - Mailing list pgsql-patches

From Alvaro Herrera
Subject partial pg_regress patch from Magnus
Date
Msg-id 20070118215601.GU26080@alvh.no-ip.org
Whole thread Raw
Responses Re: partial pg_regress patch from Magnus
List pgsql-patches
Hi,

This is a revised partial version of Magnus' patch to pg_regress.  The
only thing this patch does is remove the dependency on sed, by having
pg_regress itself generate the .sql and .out files from the .source
files.

The motivator behind this patch is allowing the Visual C++ environment
be in the buildfarm, so while I personally think it's a dumb thing to do
;-) I think the end is worthwhile.

pg_regress now needs to have the source dir in a VPATH build, to know
where to find the source files to process.  So a new --srcdir switch was
added.

I tested it in a VPATH and a normal build, and regression test still
pass.  This is mostly Magnus' code: I merely stripped out the parts
unrelated to this change, and reworked the code a little.  So the
possible bugs are likely mine.

I also changed the Makefile so that the source file list is not
explicit, but rather a $(wildcard) thing.  This is because now
pg_regress also gets the file list using a wildcard sort of thing.  (The
file list is only used in the "clean" target, so it's likely to get
desynchronized if it has to be updated manually).

Magnus' original patch is in the queue:
http://momjian.us/mhonarc/patches/msg00000.html

--
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: WIP: splitting EquivalenceClasses out from PathKeys
Next
From: Alvaro Herrera
Date:
Subject: Re: partial pg_regress patch from Magnus