Re: [HACKERS] [PATCHES] Patch to log usage of - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] [PATCHES] Patch to log usage of
Date
Msg-id 200701121644.l0CGidw14924@momjian.us
Whole thread Raw
In response to Re: [HACKERS] [PATCHES] Patch to log usage of temporary files  ("Simon Riggs" <simon@2ndquadrant.com>)
Responses Re: [HACKERS] [PATCHES] Patch to log usage oftemporary files  ("Simon Riggs" <simon@2ndquadrant.com>)
List pgsql-patches
Simon Riggs wrote:
> On Thu, 2007-01-11 at 12:37 -0500, Bruce Momjian wrote:
>
> > The trace probe was incorrect
>
> Yes, incomplete, no doubt. On that point you were 100% right to reject.
>
> > and kind of at an odd place.  I don't
> > think we want to go down the road of throwing trace in everwhere, do we?
> > I would like to see a more systematic approach to it.
>
> I guess my systematic approach was to add PG_TRACE to all new log points
> from now on, so we have a choice of which trace/log mechanism to use.

I think the right approach is to look at our existing code and come up
with places we want them, and add them in one shot.  Doing thing
in small parts doesn't work too well with a project this size.

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [GENERAL] Corrupt database? 8.1/FreeBSD6.0
Next
From: "Simon Riggs"
Date:
Subject: Re: [HACKERS] [PATCHES] Patch to log usage oftemporary files