Re: [PATCHES] Patch to log usage of temporary files - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] Patch to log usage of temporary files
Date
Msg-id 200701062228.l06MSdB08308@momjian.us
Whole thread Raw
In response to Re: [PATCHES] Patch to log usage of temporary files  (Bill Moran <wmoran@collaborativefusion.com>)
List pgsql-hackers
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


Bill Moran wrote:
> In response to Tom Lane <tgl@sss.pgh.pa.us>:
> 
> > Bill Moran <wmoran@collaborativefusion.com> writes:
> > > Andrew Dunstan <andrew@dunslane.net> wrote:
> > >>> Might be more robust to say
> > >>> if (trace_temp_files >= 0)
> > 
> > > I specified in the GUC config that minimum allowable value is -1.
> > 
> > I'd still tend to go with Andrew's suggestion because it makes this
> > particular bit of code self-defending against bad values.  Yes, it's
> > reasonably safe given that bit of coding way over yonder in guc.c,
> > but there's no particularly good reason why this code has to depend
> > on that to avoid doing something stupid.  And it's easier to understand
> > too --- you don't have to go looking in guc.c to convince yourself it's
> > safe.
> 
> Ahh ... well, I've probably already argued about it more than it's worth.
> The patch is easy enough to adjust, find attached.
> 
> -- 
> Bill Moran
> Collaborative Fusion Inc.

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by donating at
> 
>                 http://www.postgresql.org/about/donate

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Kenneth Marshall
Date:
Subject: Re: [PATCHES] [Fwd: Index Advisor]
Next
From: Tom Lane
Date:
Subject: Re: [BUGS] BUG #2873: Function that returns an empty set with a 'not null' domain errors in 8.2 but not 8.1