Here's a new version that takes into account the SELECT INTO TEMP case. Thanks
Jaime!
What other temporary objects do you think should be considered?
Any other comments on the patch?
A Dijous 04 Gener 2007 05:33, Jaime Casanova va escriure:
> On 12/27/06, Albert Cervera Areny <albertca@hotpop.com> wrote:
> > Hi,
> > here's a new version of the patch against HEAD with both, table
> > and sort files working correctly for me. Regression tests work too.
> > I'd like to ask again the question I made on the first post as no
> > answer was given at that time:
> >
> > "The GetTempTablespace function correctly returns a different tablespace
> > each time is called, but I store the position of the last tablespace used
> > with an integer and iterate through the list of tablespaces each time. I
> > tried to keep the iterator from call to call but I got a segfault, I
> > imagine due to the memory context. Should I try to keep the iterator? How
> > can I do it?"
> >
> > Now I'm working on some regression tests that could be added to
> > tablespace.source using something like:
> >
> > SET temp_tablespaces='testspace';
> >
> > CREATE TEMP TABLE temp_foo(a VARCHAR);
> >
> > SELECT COUNT(pg_ls_dir('pg_tblspc/' || (SELECT oid FROM
> > pg_catalog.pg_tablespace WHERE spcname='testspace' .... )
>
> seems is working fine... i actually looked for the files in the
> tablespace directory...
> have you looked my past comments?
