Re: [PATCHES] xlog directory at initdb time - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] xlog directory at initdb time
Date
Msg-id 200701021900.l02J0RY05709@momjian.us
Whole thread Raw
In response to Re: [PATCHES] xlog directory at initdb time  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > Am Mittwoch, 27. Dezember 2006 02:56 schrieb Euler Taveira de Oliveira:
> >> This simple patch lets someone specifies the xlog directory at initdb
> >> time. It uses symlinks to do it, and create and/or set permissions at
> >> the directory as appropriate.
> 
> > We already had this functionality in initdb a few versions ago.  Did you 
> > review why it was removed?
> 
> The discussion thread seems to start here:
> 
> http://archives.postgresql.org/pgsql-hackers/2002-08/msg00306.php
> 
> As best I can tell the objections came from the fact that Thomas had
> implemented it as a postmaster-start-time switch, which made it a
> foot-gun because you could mistakenly start the postmaster with a
> different XLOG than you were using before.  That would not apply to a
> symlink-made-by-initdb approach.  All this is doing is formalizing
> something we already suggest people do by hand...

Right.  Thomas decided he didn't want to adjust the patch based on
community input, so the patch was removed.  It was one of the few cases
where I had to back out someone else's patch against their will.

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: TODO: GNU TLS
Next
From: Lukas Kahwe Smith
Date:
Subject: Re: TODO: Add a GUC to control whether BEGIN inside