Re: bug in on_error_rollback !? - Mailing list pgsql-hackers

From Jim C. Nasby
Subject Re: bug in on_error_rollback !?
Date
Msg-id 20061030164043.GK11985@nasby.net
Whole thread Raw
In response to Re: bug in on_error_rollback !?  ("Greg Sabino Mullane" <greg@turnstep.com>)
List pgsql-hackers
On Fri, Oct 27, 2006 at 01:19:25PM -0000, Greg Sabino Mullane wrote:
> > This is documented clearly on the psql man page, so it is simply not a
> > bug, and changing this would probably break lots of legacy scripts.
> 
> In a general sense, perhaps, but in this *particular* case, I don't
> see what harm allowing "\set on_error_rollback" would be: it certainly
> won't break any existing scripts. I wrote this feature (but someone else
> chose the name!) and I still occasionally write it lowercase and wonder
> why it isn't working. :)
> 
> Perhaps even allowing all of the \set commands to be case-insensitive
> may be a good idea?

The problem is that people my be depending on the case-sensitivity in
their scripts...

\set ACounter 1
\set aCounter 2

Of course, they're just asking for trouble, but suddenly making psql
variables case-insensitive would break that code.

Perhaps a good compromise would be adopting SQL case syntax (ie: you
have to wrap in double quotes to preserve case).
-- 
Jim Nasby                                            jim@nasby.net
EnterpriseDB      http://enterprisedb.com      512.569.9461 (cell)


pgsql-hackers by date:

Previous
From: "Joshua D. Drake"
Date:
Subject: Index greater than 8k
Next
From: Tom Lane
Date:
Subject: Re: [PATCHES] WAL logging freezing