Re: Statements with syntax errors are not logged - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Statements with syntax errors are not logged
Date
Msg-id 200610191703.09368.peter_e@gmx.net
Whole thread Raw
In response to Re: Statements with syntax errors are not logged  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Statements with syntax errors are not logged  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> The 'mod' and 'ddl' settings obviously can't be handled until after
> basic parsing.  We could create a completely separate code path for
> 'all' but I'm not sure I see the point.

The users are evidently expecting that "log all statements" means to log 
all statements issued by the client.  These implementation details are 
not obvious to a user.

> To some extent the logging 
> settings are only meant to capture successfully executed statements

Then it should be changed to log *only* successfully executed statements 
and explicitly documented as such.

> (eg, you don't get duration for a failed command, either) --- which
> should be OK since failed ones won't change the database state.

I don't think tracking changes to the database state is the only 
motivation for wanting to see all statements.

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Statements with syntax errors are not logged
Next
From: "Jim C. Nasby"
Date:
Subject: Re: Additional stats for Relations