Re: ./configure argument checking - Mailing list pgsql-hackers

From Jim C. Nasby
Subject Re: ./configure argument checking
Date
Msg-id 20061013162636.GU28647@nasby.net
Whole thread Raw
In response to Re: ./configure argument checking  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: ./configure argument checking  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Oct 13, 2006 at 11:25:28AM -0400, Alvaro Herrera wrote:
> Tom Lane wrote:
> > Martijn van Oosterhout <kleptog@svana.org> writes:
> > > I would like a pedantic mode, but the method of activation is a tricky
> > > issue. You want it to be 'on' for normal users but 'off' for automatic
> > > build scripts.
> > 
> > A quiet mode would work better, because it could be on by default for 
> > both cases.  However, people may be too used to expecting to see chatter
> > from configure scripts --- anyone who's used a few before would probably
> > think the script was hung :-(
> 
> Maybe have it emit single chars instead of lines for each check?  That
> way it looks like something's going on.  Not sure how difficult that is
> with autoconf.

That would be useful, though personally I'd much rather have the default
be to error-out if it gets garbage arguments. If we provided a flag that
disabled that, all porters would have to do is to add that to the myriad
of flags they're already passing in.

In the meantime, +1 to adding some whitespace around the warning... I'd
suggest two blank lines before and after.
-- 
Jim Nasby                                            jim@nasby.net
EnterpriseDB      http://enterprisedb.com      512.569.9461 (cell)


pgsql-hackers by date:

Previous
From: "Jim C. Nasby"
Date:
Subject: Re: [PERFORM] Hints proposal
Next
From: Tom Lane
Date:
Subject: Re: [PERFORM] Hints proposal