Bruce Momjian wrote:
> How many times do I have to say this: IT IS NOT A REFACTOR PATCH AS
> REPORTED BY THE AUTHOR, AND PETER HAS NOT REFUTED THAT.
The initial patch was the feature plus some code refactoring included.
That was what the author said. I asked him to submit the refactoring
and the feature as two separate patches. What I got was a refactoring
subpatch that actually made the code longer in terms of lines, which
must be the very first code refactoring ever to achieve that. I did
not get a satisfying answer on why that has to be, so I sort of lost
interest in working with that patch.
That does not mean that the patch is bad, and I certainly support the
feature change. But I can't efficiently review the patch. If someone
else wants to do it, go ahead.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
