Re: [HACKERS] extension for sql update - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] extension for sql update
Date
Msg-id 200609030046.k830kJg25624@momjian.us
Whole thread Raw
List pgsql-patches
bruce wrote:
> I have merged your patch into current CVS and applied it; attached.
> There was quite a bit of code drift.  One drift area was the new
> RETURNING clause;  that was easy to fix.  A more complex case is the
> code no longer has values as ResTargets --- it is a simple a_expr list,
> so I changed the critical assignment in gram.y from:
>
>         res_col->val = (Node *)copyObject(res_val->val);
>
> to:
>
>     res_col->val = (Node *)copyObject(res_val);
>
> Hope that is OK.  Without that fix, it crashed.  I also merged your SGML
> syntax and grammer addition into the exiting UPDATE main entry.

The copyObject() is not required.  Removed.

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Backend SSL configuration enhancement
Next
From: Bruce Momjian
Date:
Subject: Re: [COMMITTERS] pgsql: Change FETCH/MOVE to use int8.