OK, done.
---------------------------------------------------------------------------
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Tom Lane wrote:
> >> Seems like this probably ought to round up not down:
>
> > I thought about that, but because statement_timeout is in millis, and
> > not micros, we can't have a value that gets rounded down. I am
> > thinking a cleaner solution is to check for secs and if that is 0 and
> > microsecs < 1000, you set millis = 1.
>
> This is much uglier, probably slower, and fixes the problem only for
> the zero case --- it is just as wrong to wait 1 msec when the caller
> asked for 1.5 msec. And per your own observation, statement_timeout
> is not the only source of the wait values, so this code must not
> assume that the value is a multiple of 1msec.
>
> Please do it the other way.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
