Re: tg_trigtuple/tg_newtuple settings in AFTER triggers - Mailing list pgsql-patches

From Michael Fuhr
Subject Re: tg_trigtuple/tg_newtuple settings in AFTER triggers
Date
Msg-id 20060803210019.GA17545@winnie.fuhr.org
Whole thread Raw
In response to Re: tg_trigtuple/tg_newtuple settings in AFTER triggers  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: tg_trigtuple/tg_newtuple settings in AFTER triggers  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
On Thu, Aug 03, 2006 at 12:05:23PM -0400, Tom Lane wrote:
> Michael Fuhr <mike@fuhr.org> writes:
> > Set tg_trigtuple/tg_newtuple in AFTER triggers according to whether
> > old and new tuples were supplied rather than blindly setting them
> > according to the event type.  Per discussion in pgsql-hackers.
>
> Looks good, applied.

Thanks.  Alvaro made the following suggestion but didn't copy the
list -- shall I do what he suggested and submit the changes as
another patch?

Alvaro Herrera wrote:
> I'd add an Assert() on the second hunk to make sure newtuple is only set
> in UPDATE.  And also a comment on top of the "if" to explain why.

--
Michael Fuhr

pgsql-patches by date:

Previous
From: Simon Riggs
Date:
Subject: Re: WIP archive_timeout patch
Next
From: Tom Lane
Date:
Subject: Re: tg_trigtuple/tg_newtuple settings in AFTER triggers