Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I assumed we would have a function like pg_finish_wal_segment(), and
> > server stop and stop_backup would call it too,
>
> That idea is *exactly* what I'm objecting to.
>
> > the reason being, it
> > would greatly simplify our documentation on how to use PITR if these
> > were done automatically.
>
> No it wouldn't, it'd just bloat the already excessive WAL volume.
Well, it only would happen when you have PITR enabled.
For example, if you do pg_stop_backup(), in what cases would you not
also call pg_finish_wal_segment()? I can't think of one. Maybe the
server restart case isn't necessary.
-- Bruce Momjian bruce@momjian.us EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +