Re: AIX check in datetime.h - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: AIX check in datetime.h
Date
Msg-id 200606061552.k56FqJ800746@candle.pha.pa.us
Whole thread Raw
In response to AIX check in datetime.h  (Joachim Wieland <joe@mcknight.de>)
Responses Re: AIX check in datetime.h  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Wow, that is strange.  We could remove it for 8.2 and see how testing goes.

---------------------------------------------------------------------------

Joachim Wieland wrote:
> Can someone please explain why in include/utils/datetime.h (struct datetkn)
> there is a check for _AIX that either initializes a char* pointer or a char
> array? Is there any advantage of a char-array except for warnings of some
> compilers if the initilization string is too long?
> 
> Apart from that I doubt that AIX cannot handle token[TOKMAXLEN] because
> similar declarations can be found in other headers without the _AIX check.
> 
> The struct definition is more than 9 years old and seems to show up first in
> Attic/dt.h.
> 
> 
> #define TOKMAXLEN       10      /* only this many chars are stored in
>                                  * datetktbl */
> 
> /* keep this struct small; it gets used a lot */
> typedef struct
> {
> #if defined(_AIX)
>     char       *token;
> #else
>     char        token[TOKMAXLEN];
> #endif   /* _AIX */
>     char        type;
>     char        value;          /* this may be unsigned, alas */
> } datetkn;
> 
> 
> Joachim
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
> 
>                http://www.postgresql.org/docs/faq
> 

--  Bruce Momjian   http://candle.pha.pa.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Travis Cross
Date:
Subject: Re: Duplicate rows sneaking in despite PRIMARY KEY / UNIQUE
Next
From: Tom Lane
Date:
Subject: Re: AIX check in datetime.h