[PATCH] 4 coverity patches for ECPG - Mailing list pgsql-patches

From Martijn van Oosterhout
Subject [PATCH] 4 coverity patches for ECPG
Date
Msg-id 20060423215503.GC23074@svana.org
Whole thread Raw
Responses Re: [PATCH] 4 coverity patches for ECPG  (Michael Meskes <meskes@postgresql.org>)
List pgsql-patches
Here's some patches to clear up some of the most obvious problems with
ECPG. This is just scratching the surface, but it's good to start
somewhere:

- coverity_163.diff

Strange assumption about var. The rest of the code in the function
assumes var will not be NULL, yet this one line does not.

- coverity_170.diff

Assumption that PQresultErrorField will never return NULL.

- coverity_244.diff

The code allows con to be NULL, yet if it is, this line will segfault.

- coverity_252_253.diff

Move the PGTYPESnumeric_free outside the loop to avoid the double free
possibility.

- ecpgtest.patch

A patch which add a "make check" to the ecpg/test directory. I don't
expect this to be committed to CVS, but it's provided as an example of
the tests the above patches pass.
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.

Attachment

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Additional current timestamp values
Next
From: Tom Lane
Date:
Subject: Re: Building with Visual C++