Re: pg_ctl options checking - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: pg_ctl options checking
Date
Msg-id 200604141446.k3EEk8c14413@candle.pha.pa.us
Whole thread Raw
In response to pg_ctl options checking  (Simon Riggs <simon@2ndquadrant.com>)
List pgsql-patches
Your patch has been added to the PostgreSQL unapplied patches list at:

    http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


Simon Riggs wrote:
> pg_ctl: Minor patch to implement option checking to prevent silently
> ignoring options and continuing with defaults.
>
> All of the following now cause errors:
>
> pg_ctl -D test -m logfile start
> pg_ctl -D test -U foo start
> pg_ctl -D test -W start
> pg_ctl -D test -w stop
> pg_ctl -D test -l fast stop
> etc.. (16 possible error combinations in total now checked)
>
> The following also fails, following the --help, though I think we might
> want to change this so that it does actually work:
>
> pg_ctl -D test -l logfile restart
>
> Patch against cvstip, make check, tested on long and short options.
>
> --
>   Simon Riggs
>   EnterpriseDB   http://www.enterprisedb.com

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

--
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Simon Riggs
Date:
Subject: pg_ctl options checking
Next
From: "Nicolas Barbier"
Date:
Subject: Documentation patch: change a name in a grammar rule to prevent confusion