Re: not checking value returned from palloc? - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: not checking value returned from palloc?
Date
Msg-id 20060319221022.GA5357@surnet.cl
Whole thread Raw
In response to Re: not checking value returned from palloc?  (Mark Dilger <pgsql@markdilger.com>)
Responses Re: not checking value returned from palloc?  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Mark Dilger wrote:
> Peter Eisentraut wrote:
> >Mark Dilger wrote:
> >
> >>Looking through the postgresql source code, I notice that there are
> >>many places were palloc is used but the return value is not checked
> >>to see if it is null.
> >
> >palloc will throw an exception if it cannot fulfill the request.  Code 
> >that checks the return value for null is in fact a waste.
> 
> Interesting.  So the patch should go the other way, and remove the checks 
> that are currently in the code?

Yes, if you find any such place please submit a patch.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: not checking value returned from palloc?
Next
From: Bruce Momjian
Date:
Subject: Re: not checking value returned from palloc?