Re: implement prepared queries in plperl - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: implement prepared queries in plperl
Date
Msg-id 200603012242.k21MgeU26583@candle.pha.pa.us
Whole thread Raw
In response to Re: implement prepared queries in plperl  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: implement prepared queries in plperl  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-patches
Is this patch going to be applied?

---------------------------------------------------------------------------

Andrew Dunstan wrote:
>
>
> Dmitry Karasik wrote:
>
> [patch snipped]
>
> I have cleaned this patch somewhat by removing some bitrot that occurred
> since it was submitted, and adjusting formatting to something more
> closely resembling postgresql style (please remember to follow our style
> in future).
>
> The attached works on HEAD and passes the supplied regression tests.
>
> But why do we have to call spi_freeplan? pltcl, which has prepared
> queries, doesn't require this AFAICS. If memory leaks are an issue,
> maybe we should bless the object into a class with a DESTROY method that
> calls spi_freeplan automatically (not sure to do that in XS but I assume
> it's possible).
>
> cheers
>
> andrew
>
>


>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
>                http://archives.postgresql.org

--
  Bruce Momjian   http://candle.pha.pa.us
  SRA OSS, Inc.   http://www.sraoss.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Patch Submission Guidelines
Next
From: Andrew Dunstan
Date:
Subject: Re: implement prepared queries in plperl