Re: pgsql: Added just another test case. - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Added just another test case.
Date
Msg-id 200602081545.k18FjwQ18496@candle.pha.pa.us
Whole thread Raw
In response to Re: pgsql: Added just another test case.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Yes, it is the yydebug check.  I am thinking we should just comment out
the check until we get it fixed.

---------------------------------------------------------------------------

Tom Lane wrote:
> meskes@postgresql.org (Michael Meskes) writes:
> > Log Message:
> > -----------
> >  Added just another test case.
> >  Fixed missing continuation line character.
> >  Do not translate $-quoting.
> >  Bit field notation belongs to a variable not a variable list.
> >  Output of line number only done by one function.
>
> This commit seems to have broken HEAD:
>
> bison -y -d  preproc.y
> mv -f y.tab.c ./preproc.c
> mv -f y.tab.h ./preproc.h
> /usr/bin/flex  -o'pgc.c' pgc.l
> ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels
-fno-strict-aliasing-g -Wno-error -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -I./../include -I.
-I../../../../src/include-D_GNU_SOURCE  -I/usr/include/et -DMAJOR_VERSION=4 -DMINOR_VERSION=2 -DPATCHLEVEL=1  -c -o
preproc.opreproc.c 
> In file included from preproc.y:6614:
> pgc.c: In function `yylex':
> pgc.c:1522: warning: label `find_rule' defined but not used
> preproc.y: At top level:
> pgc.c:3678: warning: 'yy_flex_realloc' defined but not used
> ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels
-fno-strict-aliasing-g -Wno-error -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -I./../include -I.
-I../../../../src/include-D_GNU_SOURCE  -I/usr/include/et -DMAJOR_VERSION=4 -DMINOR_VERSION=2 -DPATCHLEVEL=1  -c -o
type.otype.c 
> ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels
-fno-strict-aliasing-g -Wno-error -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -I./../include -I.
-I../../../../src/include-D_GNU_SOURCE  -I/usr/include/et -DMAJOR_VERSION=4 -DMINOR_VERSION=2 -DPATCHLEVEL=1  -c -o
ecpg.oecpg.c 
> ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels
-fno-strict-aliasing-g -Wno-error -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -I./../include -I.
-I../../../../src/include-D_GNU_SOURCE  -I/usr/include/et -DMAJOR_VERSION=4 -DMINOR_VERSION=2 -DPATCHLEVEL=1  -c -o
ecpg_keywords.oecpg_keywords.c 
> ccache gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels
-fno-strict-aliasing-g -Wno-error -pthread  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS -I./../include -I.
-I../../../../src/include-D_GNU_SOURCE  -I/usr/include/et -DMAJOR_VERSION=4 -DMINOR_VERSION=2 -DPATCHLEVEL=1  -c -o
output.ooutput.c 
> output.c: In function `hashline_number':
> output.c:90: error: `yydebug' undeclared (first use in this function)
> output.c:90: error: (Each undeclared identifier is reported only once
> output.c:90: error: for each function it appears in.)
> make[4]: *** [output.o] Error 1
>
>             regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Added just another test case.
Next
From: tgl@postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix broken non-YYDEBUG case.