Re: [BUGS] BUG #2120: Crash when doing UTF8<->ISO_8859_8 - Mailing list pgsql-patches

From Tatsuo Ishii
Subject Re: [BUGS] BUG #2120: Crash when doing UTF8<->ISO_8859_8
Date
Msg-id 20051224.092723.123398431.t-ishii@sraoss.co.jp
Whole thread Raw
In response to Re: [BUGS] BUG #2120: Crash when doing UTF8<->ISO_8859_8 encoding  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
> Tatsuo Ishii <ishii@sraoss.co.jp> writes:
> > I think the current implementaion in utf8_and_iso8859.c is fast but
> > too fragile against rearranging of encoding id. I modify those functions
> > in utf8_and_iso8859.c to do a linear search with encoding id.
>
> That's not unreasonable, but I was wondering whether we could add some
> Assert() tests that would catch problems without imposing any extra cost
> in normal non-Assert builds.

I thought about that too. But my conclusion was current code is too
hard to maintain even if appropreate comments are written in related
files.
--
Tatsuo Ishii
SRA OSS, Inc. Japan

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: default resource limits
Next
From: Peter Eisentraut
Date:
Subject: Re: default resource limits