Re: Strange interval arithmetic - Mailing list pgsql-hackers

From Michael Fuhr
Subject Re: Strange interval arithmetic
Date
Msg-id 20051130221823.GA27181@winnie.fuhr.org
Whole thread Raw
In response to Re: Strange interval arithmetic  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Strange interval arithmetic  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Nov 30, 2005 at 07:06:42PM -0300, Alvaro Herrera wrote:
> Hmm, why not check both the return value _and_ errno:
> 
> val = strtol(field[i], &cp, 10);
> if (val == LONG_MAX && errno == ERANGE)
>     return DTERR_FIELD_OVERFLOW;

I usually check both in my own code but I noticed several places
where PostgreSQL doesn't, so I kept that style.  I'll check both
if that's preferred.

-- 
Michael Fuhr


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Strange interval arithmetic
Next
From: Tom Lane
Date:
Subject: Re: Strange interval arithmetic