Re: [PATCH] Formatting patch for psql - Mailing list pgsql-patches

From Martijn van Oosterhout
Subject Re: [PATCH] Formatting patch for psql
Date
Msg-id 20051124201146.GB29774@svana.org
Whole thread Raw
In response to Re: [PATCH] Formatting patch for psql  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: [PATCH] Formatting patch for psql  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
On Thu, Nov 24, 2005 at 03:45:12PM +0100, Peter Eisentraut wrote:
> Shouldn't you use PQmblen() to determine whether an encoding is
> single-byte, rather than having an enumerated list?

Actually, thinking about it the answer is no. The code is relying on
the fact that it's a charset that has ASCII as a subset. Unless someone
can say that every single-byte encoding we support has an ASCII subset
(EBCDIC being the obvious counter-example for not supported encodings)
then I think we have to stick to enumerating them.

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.

Attachment

pgsql-patches by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Space management for PGresult
Next
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] Formatting patch for psql