psqlodbc - psqlodbc: When EN_Destructor is called it searches through - Mailing list pgsql-committers

From dpage@pgfoundry.org (User Dpage)
Subject psqlodbc - psqlodbc: When EN_Destructor is called it searches through
Date
Msg-id 20051025073854.9A1E41125023@pgfoundry.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
When EN_Destructor is called it searches through the connection array
and destroys any connections which belong that environment. Unfortunately
it doesn't NULL out the connection array entry afterwards so a future
call to EN_Destructor can wind up trying to destroy that connection
again if another environment has been allocated at the same address.

Also, shouldn't EN_Destructor hold the CONNS critical section while it
is playing with the connection array?

The attached patch fixes both of these issues and seems to have fixed
the crashes I was observing.
[Tom Hughes]

Modified Files:
--------------
    psqlodbc:
        environ.c (r1.54 -> r1.55)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/psqlodbc/psqlodbc/environ.c.diff?r1=1.54&r2=1.55)

pgsql-committers by date:

Previous
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: IBM has addressed the socket address storage issue as of AIX 5.3
Next
From: dpage@pgfoundry.org (User Dpage)
Date:
Subject: psqlodbc - psqlodbc: This patch fixes a potential segfault that can