pgsql: Code review for spi_query/spi_fetchrow patch: handle errors - Mailing list pgsql-committers

From tgl@svr1.postgresql.org (Tom Lane)
Subject pgsql: Code review for spi_query/spi_fetchrow patch: handle errors
Date
Msg-id 20051018171314.60F25D94DD@svr1.postgresql.org
Whole thread Raw
Responses Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors  (David Fetter <david@fetter.org>)
List pgsql-committers
Log Message:
-----------
Code review for spi_query/spi_fetchrow patch: handle errors sanely,
avoid leaking memory.  I would add a regression test for error handling
except it seems eval{} can't be used in unprivileged plperl :-(

Modified Files:
--------------
    pgsql/src/pl/plperl:
        SPI.xs (r1.16 -> r1.17)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/SPI.xs.diff?r1=1.16&r2=1.17)
        plperl.c (r1.93 -> r1.94)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c.diff?r1=1.93&r2=1.94)

pgsql-committers by date:

Previous
From: doudou586@pgfoundry.org (User Doudou586)
Date:
Subject: press - pr: version 1.0
Next
From: David Fetter
Date:
Subject: Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors