Re: [HACKERS] Patching dblink.c to avoid warning about - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] Patching dblink.c to avoid warning about
Date
Msg-id 200510171236.j9HCa0L00844@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Patching dblink.c to avoid warning about  (Joe Conway <mail@joeconway.com>)
Responses Re: [HACKERS] Patching dblink.c to avoid warning about
List pgsql-patches
Joe Conway wrote:
> Tom Lane wrote:
> > I think it would be shorter and clearer to write
> >
> >     remoteConn  *remconn = NULL;
> >     ...
> >     remconn = rconn;
> >     ...
> >     remconn->newXactForCursor = TRUE;
> >
> > Also, you might be able to combine this variable with the existing
> > rconn local variable and thus simplify the code even more.
>
> Thanks for the review Tom -- as usual, great suggestions. The attached
> (simpler) patch makes use of your advice. If there are no objections,
> I'll apply this tomorrow evening.

Looks good.  Thanks.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: NosyMan
Date:
Subject: Can I use variable to store sql data?
Next
From: Peter Eisentraut
Date:
Subject: Re: Can I use variable to store sql data - II