Re: pgsql: Fix (hopefully for the last time) problems with datetime values - Mailing list pgsql-committers

From Michael Fuhr
Subject Re: pgsql: Fix (hopefully for the last time) problems with datetime values
Date
Msg-id 20051009232740.GA59285@winnie.fuhr.org
Whole thread Raw
In response to Re: pgsql: Fix (hopefully for the last time) problems with datetime values  (Larry Rosenman <ler@lerctr.org>)
List pgsql-committers
On Sun, Oct 09, 2005 at 03:43:20PM -0500, Larry Rosenman wrote:
> On Oct 9, 2005, at 1:56 PM, Michael Fuhr wrote:
> >This change causes my FreeBSD 4.11-STABLE box and a couple of
> >FreeBSD 6 members of the buildfarm to fail while building ecpg:
> >
> >timestamp.c: In function `timestamp2tm':
> >timestamp.c:195: `INT_MAX' undeclared (first use in this function)
> >
> >Including <limits.h> in src/interfaces/ecpg/pgtypeslib/timestamp.c
> >fixes the problem.
>
> firefly (my UnixWare box as well) dies with this.

When you say "firefly dies with this," which "this" are you referring
to?  The original change, my suggestion to include <limits.h>, or both?
At least the first, apparently:

http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=firefly&dt=2005-10-09%2020:27:01

My Solaris 9 box also failed with the original change.

--
Michael Fuhr

pgsql-committers by date:

Previous
From: Larry Rosenman
Date:
Subject: Re: pgsql: Fix (hopefully for the last time) problems with datetime values
Next
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql: is now needed here, for INT_MAX.