Re: pgsql: Fix (hopefully for the last time) problems with datetime values - Mailing list pgsql-committers

From Michael Fuhr
Subject Re: pgsql: Fix (hopefully for the last time) problems with datetime values
Date
Msg-id 20051009185642.GA53305@winnie.fuhr.org
Whole thread Raw
In response to pgsql: Fix (hopefully for the last time) problems with datetime values  (tgl@svr1.postgresql.org (Tom Lane))
Responses Re: pgsql: Fix (hopefully for the last time) problems with datetime values  (Larry Rosenman <ler@lerctr.org>)
Re: pgsql: Fix (hopefully for the last time) problems with datetime values  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Sun, Oct 09, 2005 at 02:21:47PM -0300, Tom Lane wrote:
> Fix (hopefully for the last time) problems with datetime values displaying
> like '23:59:60' because of fractional-second roundoff problems.  Trying
> to control this upstream of the actual display code was hopeless; the right
> way is to explicitly round fractional seconds in the display code and then
> refigure the results if the fraction rounds up to 1.  Per bug #1927.

This change causes my FreeBSD 4.11-STABLE box and a couple of FreeBSD 6
members of the buildfarm to fail while building ecpg:

timestamp.c: In function `timestamp2tm':
timestamp.c:195: `INT_MAX' undeclared (first use in this function)

Including <limits.h> in src/interfaces/ecpg/pgtypeslib/timestamp.c
fixes the problem.

--
Michael Fuhr

pgsql-committers by date:

Previous
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql: Fix (hopefully for the last time) problems with datetime values
Next
From: Larry Rosenman
Date:
Subject: Re: pgsql: Fix (hopefully for the last time) problems with datetime values