Postgres Pro
Downloads
Home   >   mailing lists

pgsql: Factor out the common subexpression month_remainder * - Mailing list pgsql-committers

From tgl@svr1.postgresql.org (Tom Lane)
Subject pgsql: Factor out the common subexpression month_remainder *
Date
Msg-id 20050825050143.65677D7A57@svr1.postgresql.org
Whole thread Raw
List pgsql-committers
Tree view 
Log Message:
-----------
Factor out the common subexpression month_remainder * DAYS_PER_MONTH
in interval_mul and interval_div.  This avoids an optimization bug
in A Certain Company's compiler (and given their explanation, I wouldn't
be surprised if other compilers blow it too).  Besides the code seems
more clear this way --- in the original formulation, you had to mentally
recognize the common subexpression in order to understand what was going
on.

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        timestamp.c (r1.150 -> r1.151)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/timestamp.c.diff?r1=1.150&r2=1.151)

pgsql-committers by date:

Previous
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Back out pfrees for justify_hour function calls.
Next
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql: Replace out-of-line tas() assembly code for MIPS with a properly