Re: [HACKERS] Followup on the UnixWare Optimizer bug. - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] Followup on the UnixWare Optimizer bug.
Date
Msg-id 200508250353.j7P3rbI16174@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Followup on the UnixWare Optimizer bug.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Good catch on the memory leak.  I have applied the following fix.
>
> These explicit pfrees are a waste of time, and probably actually
> counterproductive as far as speed goes, because these functions
> will always be invoked in relatively short-lived memory contexts.
>
> I wouldn't object except that they seem to make the code noticeably
> more obscure.

OK, patch reverted.  I am often unsure where we do quick cleanup and
were we don't.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Followup on the UnixWare Optimizer bug.
Next
From: "Dave Page"
Date:
Subject: Re: [HACKERS] Proposed patch to getaddrinfo.c to support