Re: [PATCHES] Duplicate object names in GRANT - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [PATCHES] Duplicate object names in GRANT
Date
Msg-id 200508122120.j7CLKdL15764@candle.pha.pa.us
Whole thread Raw
In response to Re: Duplicate object names in GRANT  (Gavin Sherry <swm@linuxworld.com.au>)
List pgsql-hackers
Patch applied.  Thanks.

I also added a comment above each one to mention why it is needed.

---------------------------------------------------------------------------


Gavin Sherry wrote:
> On Wed, 27 Jul 2005, Tom Lane wrote:
>
> > Gavin Sherry <swm@linuxworld.com.au> writes:
> > > I ran across this yesterday on HEAD:
> >
> > > template1=# grant select on foo, foo to swm;
> > > ERROR:  tuple already updated by self
> >
> > Seems to fail similarly in every version back to 7.2; probably further,
> > but that's all I have running at the moment.
> >
> > > We could do away with the error by producing a unique list of object names
> > > -- but that would impose an extra cost on the common case.
> >
> > CommandCounterIncrement in the GRANT loop would be easier, likely.
> > I'm having a hard time getting excited about it though...
>
> Yeah, its not that exciting but that error message would throw your
> average user.
>
> I've attached a patch which calls CommandCounterIncrement() in each of the
> grant loops.
>
> Thanks,
>
> Gavin

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pthread stack on FreeBSD WAS: HEAD doesn't cope with libraries
Next
From: Tom Lane
Date:
Subject: Re: [PATCH] Determining return type of polymorphic function