Re: Bug in canonicalize_path() - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Bug in canonicalize_path()
Date
Msg-id 200508120315.j7C3FPu14988@candle.pha.pa.us
Whole thread Raw
In response to Re: Bug in canonicalize_path()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Bug in canonicalize_path()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > But what about "usr/local/../../.."?
>
> What about it?  The case of /usr/local/../../.. is handled correctly,
> and the case where it's an underspecified relative path doesn't seem
> that interesting to me --- certainly that is not so important that we
> should get the wrong answer on cases that *are* plausible.
>
> Most of the uses of canonicalize_path are on paths that are required to
> be absolute, anyway.
>
> It wouldn't be too implausible to error out if pending_strips>0 after
> exiting the loop.

I figured it would be best to leave it alone if we can't process it, but
if you think it is more imporant to trim in cases like ../.., go ahead.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Bug in canonicalize_path()
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] For review: Server instrumentation patch