Re: enable/disable trigger (Re: Fwd: [HACKERS] Open items) - Mailing list pgsql-patches

On Mon, Aug 08, 2005 at 08:07:05AM +0900, Satoshi Nagayasu wrote:
> Here is new patch with pg_dump modification.

There are a few elog() calls that should really be ereport().  Also
this message

> +     elog(NOTICE, "%d trigger(s) on %s %s.",
> +          changed,
> +          NameStr(rel->rd_rel->relname),
> +          enable ? "enabled" : "disabled");

should really be two messages (Maybe even four: disabled-plural,
disabled-singular, enabled-plural, enabled-singular)


There's a SQL typo here:

> +             appendPQExpBuffer(query, "ALTER TABLE %s DIABLE TRIGGER %s;\n",

--
Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
"La conclusión que podemos sacar de esos estudios es que
no podemos sacar ninguna conclusión de ellos" (Tanenbaum)