SVN Commit by dpage: r4380 - in trunk/pgadmin3: . src/dlg - Mailing list pgadmin-hackers

From svn@pgadmin.org
Subject SVN Commit by dpage: r4380 - in trunk/pgadmin3: . src/dlg
Date
Msg-id 200507210826.j6L8QwsG007217@developer.pgadmin.org
Whole thread Raw
Responses Re: SVN Commit by dpage: r4380 - in trunk/pgadmin3:  (Andreas Pflug <pgadmin@pse-consulting.de>)
List pgadmin-hackers
Author: dpage
Date: 2005-07-21 09:26:58 +0100 (Thu, 21 Jul 2005)
New Revision: 4380

Modified:
   trunk/pgadmin3/CHANGELOG.txt
   trunk/pgadmin3/src/dlg/dlgTable.cpp
Log:
Prompt the user before removing columns, constraints or inherited tables in the table dialogue, per gripe from Anoop
Kumar.

Modified: trunk/pgadmin3/CHANGELOG.txt
===================================================================
--- trunk/pgadmin3/CHANGELOG.txt    2005-07-06 10:26:21 UTC (rev 4379)
+++ trunk/pgadmin3/CHANGELOG.txt    2005-07-21 08:26:58 UTC (rev 4380)
@@ -17,6 +17,7 @@
 </ul>
 <br>
 <ul>
+    <li>2005-07-21 DP        Prompt the user before removing columns, constraints or inherited tables in the table
dialogue.
     <li>2005-07-06 DP        Prompt the user to cancel running queries before closing the Query tool.
     <li>2005-07-04 DP        Check for and display asynchronous notifications in the query tool.
     <li>2005-06-21 AP        typo fixes, rename "initial db" to "maintenance db"

Modified: trunk/pgadmin3/src/dlg/dlgTable.cpp
===================================================================
--- trunk/pgadmin3/src/dlg/dlgTable.cpp    2005-07-06 10:26:21 UTC (rev 4379)
+++ trunk/pgadmin3/src/dlg/dlgTable.cpp    2005-07-21 08:26:58 UTC (rev 4380)
@@ -596,6 +596,9 @@

 void dlgTable::OnRemoveTable(wxCommandEvent &ev)
 {
+    if (wxMessageBox(_("Are you sure you wish to remove the selected table?"), _("Remove table?"), wxYES_NO |
wxNO_DEFAULT| wxICON_QUESTION) == wxNO) 
+        return;
+
     int sel=lbTables->GetSelection();
     if (sel >= 0)
     {
@@ -665,6 +668,9 @@

 void dlgTable::OnRemoveCol(wxCommandEvent &ev)
 {
+    if (wxMessageBox(_("Are you sure you wish to remove the selected column?"), _("Remove column?"), wxYES_NO |
wxNO_DEFAULT| wxICON_QUESTION) == wxNO) 
+        return;
+
     lstColumns->DeleteCurrentItem();

     btnRemoveCol->Disable();
@@ -742,6 +748,9 @@

 void dlgTable::OnRemoveConstr(wxCommandEvent &ev)
 {
+    if (wxMessageBox(_("Are you sure you wish to remove the selected constraint?"), _("Remove constraint?"), wxYES_NO
|wxNO_DEFAULT | wxICON_QUESTION) == wxNO) 
+        return;
+
     int pos=lstConstraints->GetSelection();
     if (pos < 0)
         return;


pgadmin-hackers by date:

Previous
From: Francisco Javier Jiménez Gómez
Date:
Subject: SECURITY BUG.
Next
From: Andreas Pflug
Date:
Subject: Re: SVN Commit by dpage: r4380 - in trunk/pgadmin3: