Re: TODO Item - Return compressed length of TOAST datatypes - Mailing list pgsql-patches

From Alvaro Herrera
Subject Re: TODO Item - Return compressed length of TOAST datatypes
Date
Msg-id 20050707032823.GA26942@alvh.no-ip.org
Whole thread Raw
In response to Re: TODO Item - Return compressed length of TOAST datatypes  (Mark Kirkwood <markir@paradise.net.nz>)
Responses Re: TODO Item - Return compressed length of TOAST datatypes  (Mark Kirkwood <markir@paradise.net.nz>)
Re: TODO Item - Return compressed length of TOAST datatypes  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
On Thu, Jul 07, 2005 at 03:01:46PM +1200, Mark Kirkwood wrote:
> Neil Conway wrote:

> >elog(ERROR) is usually used for "can't happen" errors; also, the usual
> >error message in this scenario is "cache lookup failed [...]". Perhaps
> >better to use get_typlen() here, anyway.
>
> I have attached a little change to varlena.c that uses it. I left the
> ereport as it was, but am not fussed about it either way.

I am, because it gives useless messages to the translators to work on.
elog parameters are not marked for translation, ereport are (errmsg and
friends, really).  So please don't do that.

--
Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
"¿Cómo puedes confiar en algo que pagas y que no ves,
y no confiar en algo que te dan y te lo muestran?" (Germán Poo)

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: TODO Item - Return compressed length of TOAST datatypes
Next
From: Mark Kirkwood
Date:
Subject: Re: TODO Item - Return compressed length of TOAST datatypes