Re: [HACKERS] HEAD doesn't cope with libraries in non-default - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] HEAD doesn't cope with libraries in non-default
Date
Msg-id 200507040415.j644FoY16458@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] HEAD doesn't cope with libraries in non-default locations  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] HEAD doesn't cope with libraries in non-default  ("Andrew Dunstan" <andrew@dunslane.net>)
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Tom Lane wrote:
> >> It appears that somebody has changed things so that the -L switches
> >> appear after the -l switches (ie, too late).  I'm too tired to
> >> investigate now, but my money is on Autoconf 2.59 being the problem ...
>
> > I wonder if it was this commit.  I am attaching the patch so you can
> > test to see if it fixes it.  If it does, please let us know.
>
> > ! SHLIB_LINK := $(filter -L%, $(LDFLAGS)) $(SHLIB_LINK)
> > ...
> > ! SHLIB_LINK := $(SHLIB_LINK) $(filter -L%, $(LDFLAGS))
>
> Urgh.  This was considered a good idea why exactly?

I didn't like it myself but it fixed a problem with a build farm
machine, and no one objected, so I applied it, but it seemed pretty
strange to be reversing those. I will reverse the patch.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] HEAD doesn't cope with libraries in non-default locations
Next
From: Tom Lane
Date:
Subject: Re: Constraint Exclusion (Partitioning) - Initial Review