Re: process crash when a plpython function returns unicode - Mailing list pgsql-hackers

From Michael Fuhr
Subject Re: process crash when a plpython function returns unicode
Date
Msg-id 20050618144115.GA91757@winnie.fuhr.org
Whole thread Raw
Responses Re: process crash when a plpython function returns
List pgsql-hackers
I've moved this thread from pgsql-bugs to pgsql-hackers; here are
the original messages:

http://archives.postgresql.org/pgsql-bugs/2005-06/msg00105.php
http://archives.postgresql.org/pgsql-bugs/2005-06/msg00107.php

As I mentioned in my followup to the bug report, a simple fix would
appear to be to check for a NULL return value from PyObject_Str()
before calling PyString_AsString() at the following location:
   /* Lines 776-77 in plpython.c */   plrv_so = PyObject_Str(plrv);   plrv_sc = PyString_AsString(plrv_so);

I was going to submit a patch, but I don't know enough about the
Python API or how Python and PostgreSQL handle Unicode to know
whether adding that simple check is the appropriate solution (I was
planning to raise an error if PyObject_Str() returned NULL).  Can
anybody think of a better fix?

-- 
Michael Fuhr
http://www.fuhr.org/~mfuhr/


pgsql-hackers by date:

Previous
From: Bruno Wolff III
Date:
Subject: Re: LGPL
Next
From: Tino Wildenhain
Date:
Subject: Re: [PATCHES] default database creation with initdb