Re: [PATCHES] regexp_replace - Mailing list pgsql-hackers

From Tom Flavel
Subject Re: [PATCHES] regexp_replace
Date
Msg-id 20050609020702.GB12557@printf.net
Whole thread Raw
In response to Re: [PATCHES] regexp_replace  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
On 08/06/2005 21:57:29, Bruce Momjian wrote:
> Andrew Dunstan wrote:
> > Atsushi Ogawa said:
> > >
> > > How about changing the function name of each usage?
> > >
> > > regexp_replace:        replace first
> > > regexp_replace_all:    replace all
> > > regexp_ic_replace:     replace first and case insensitive
> > > regexp_ic_replace_all: replace all and case insensitive
> > 
> > 
> > That's just horrible. The number of function names will double with each
> > supported flag (e.g. I'd like to see extended regexes supported).
> > 
> > surely somthing like
> > 
> >   foo_replace (source text, pattern text, replacement text, flags text)
> > returns text
> > 
> > would fit the bill. OK, it reflects my Perl prejudices, but that looks more
> > natural to me. You could overload it so that the flags default to none
> > (which would be case sensitive, replace the first instance only, among other
> > things).
> 
> Can we have the flags be a list of words, e.g.  "all, ignorecase".  How
> do we handle this type of problem in other cases?

How about an array?

Cumbersome, perhaps, but it makes more sense to me than delimiting with
commas or using single characters.

-- 
Tom


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: I am up-to-date
Next
From: Bruce Momjian
Date:
Subject: Re: linuxtag 2005