Re: libpq API incompatibility between 7.4 and 8.0 - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: libpq API incompatibility between 7.4 and 8.0
Date
Msg-id 20050607044238.GC15923@surnet.cl
Whole thread Raw
In response to Re: libpq API incompatibility between 7.4 and 8.0  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
On Mon, Jun 06, 2005 at 09:23:21PM -0400, Bruce Momjian wrote:
> 
> Is this a direction we want to explore --- using the SONAME as part of
> the translation domain?

Hm, interesting -- this could explain some weird problems I've had with
translated text on a machine where multiple versions are installed.
I'll investigate a bit and if it turns out to be solved by this
approach, it has my vote.

However I think we should stay away from using the version number as a
string inside the source.  If we do tht, we will forget to increment it
in the future and we will have problems.

> > In my test packages I used the following patch:
> > 
> > diff -ruN postgresql-8.0.1-old/src/interfaces/libpq/fe-misc.c postgresql-8.0.1/src/interfaces/libpq/fe-misc.c
> > --- postgresql-8.0.1-old/src/interfaces/libpq/fe-misc.c 2004-12-31 23:03:50.000000000 +0100
> > +++ postgresql-8.0.1/src/interfaces/libpq/fe-misc.c     2005-02-07 22:55:13.177419296 +0100
> > @@ -1133,7 +1133,7 @@
> >         {
> >                 already_bound = 1;
> >                 /* No relocatable lookup here because the binary could be anywhere */
> > -               bindtextdomain("libpq", getenv("PGLOCALEDIR") ? getenv("PGLOCALEDIR") : LOCALEDIR);
> > +               bindtextdomain("libpq4", getenv("PGLOCALEDIR") ? getenv("PGLOCALEDIR") : LOCALEDIR);
> >         }

-- 
Alvaro Herrera (<alvherre[a]surnet.cl>)
"La experiencia nos dice que el hombre peló millones de veces las patatas,
pero era forzoso admitir la posibilidad de que en un caso entre millones,
las patatas pelarían al hombre" (Ijon Tichy)


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Should *.backup files ever be removed from pg_xlog?
Next
From: Christopher Kings-Lynne
Date:
Subject: Re: [PATCHES] lastval()