pgsql: Cleanup GiST header files. - Mailing list pgsql-committers

Log Message:
-----------
Cleanup GiST header files. Since GiST extensions are often written as
external projects, we should be careful about what parts of the GiST
API are considered implementation details, and which are part of the
public API. Therefore, I've moved internal-only declarations into
gist_private.h -- future backward-incompatible changes to gist.h should
be made with care, to avoid needlessly breaking external GiST extensions.

Also did some related header cleanup: remove some unnecessary #includes
from gist.h, and remove some unused definitions: isAttByVal(), _gistdump(),
and GISTNStrategies.

Modified Files:
--------------
    pgsql/contrib/cube:
        cube.c (r1.18 -> r1.19)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/cube.c.diff?r1=1.18&r2=1.19)
    pgsql/src/backend/access/gist:
        gist.c (r1.116 -> r1.117)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gist/gist.c.diff?r1=1.116&r2=1.117)
        gistget.c (r1.46 -> r1.47)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gist/gistget.c.diff?r1=1.46&r2=1.47)
        gistscan.c (r1.57 -> r1.58)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gist/gistscan.c.diff?r1=1.57&r2=1.58)
    pgsql/src/backend/access/transam:
        rmgr.c (r1.16 -> r1.17)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/rmgr.c.diff?r1=1.16&r2=1.17)
    pgsql/src/include/access:
        gist.h (r1.45 -> r1.46)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/access/gist.h.diff?r1=1.45&r2=1.46)

Added Files:
-----------
    pgsql/src/include/access:
        gist_private.h (r1.1)

(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/access/gist_private.h?rev=1.1&content-type=text/x-cvsweb-markup)