Tom,
> On re-reading the thread, I'm more than a bit confused by this response.
> I thought you were suggesting that the top-level configure should have
> a simple option that says "please build and install all the contrib
> modules while you are at it". Right now that requires a separate step
> "cd contrib; make; make install" which I agree could be handled by a
> top-level configure option. And it would also be reasonable for "make
> check" at the top level to include running the contrib regression tests
> if this option had been specified. (Memo to Andrew Dunstan: that should
> also happen for the PL-specific tests, as soon as they've been
> pg_regress-ified.)
Well, that depends on whether you're talking me, personally, or the packagers.
I agree that the packagers are more likely to want a --make-all-contrib. I
personally would prefer a --make-contrib="tsearch2,ltree,intarray" which
allows me to build selected modules. Also, if we are going to add
useful-but-potentially-dangerous stuff like the "admin commands" to /contrib,
then even the packagers will want options.
What could be a great all-around option would be to put stuff potentially in
contrib into about 3 groups, like "datatypes", "sqltools" and "admintools".
Then you'd have three options --with-contrib-types, --with-contrib-sql, and
--with-contrib-admin, and of course --with-contrib-all. The reason for the
distinction is that some packagers might want everything but the admin tools
becuase those have potential security issues.
Anyway, that's a bit incoherent, but do people see what I mean with this?
--
Josh Berkus
Aglio Database Solutions
San Francisco
