pgsql: Make equalTupleDescs() compare attlen/attbyval/attalign rather - Mailing list pgsql-committers

From tgl@svr1.postgresql.org (Tom Lane)
Subject pgsql: Make equalTupleDescs() compare attlen/attbyval/attalign rather
Date
Msg-id 20050414223449.2AEE053661@svr1.postgresql.org
Whole thread Raw
List pgsql-committers
Log Message:
-----------
Make equalTupleDescs() compare attlen/attbyval/attalign rather than
assuming comparison of atttypid is sufficient.  In a dropped column
atttypid will be 0, and we'd better check the physical-storage data
to make sure the tupdescs are physically compatible.
I do not believe there is a real risk before 8.0, since before that
we only used this routine to compare successive states of the tupdesc
for a particular relation.  But 8.0's typcache.c might be comparing
arbitrary tupdescs so we'd better play it safer.

Modified Files:
--------------
    pgsql/src/backend/access/common:
        tupdesc.c (r1.110 -> r1.111)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/common/tupdesc.c.diff?r1=1.110&r2=1.111)

pgsql-committers by date:

Previous
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql: Put back blessing of record-function tupledesc, which I removed
Next
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql: Make equalTupleDescs() compare attlen/attbyval/attalign rather