Re: Faster install-sh in C - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Faster install-sh in C
Date
Msg-id 200503252323.j2PNN4526469@candle.pha.pa.us
Whole thread Raw
In response to Re: Faster install-sh in C  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Tom Lane wrote:
> >> We might be able to get away with this for just the headers, though,
> >> and that's certainly the bulk of the install work now.
>
> > Here is my next version of the patch that uses 'cp' and 'chmod' to
> > install multiple header files rather than 'install'.
>
> > I moved the file modes into variables so any changes are propogated to
> > src/include/Makefile.
>
> > This is 20 times faster than what we have now, 8 seconds vs 0.40 seconds.
>
> I like it.  Given that we are installing into directories we'd have just
> created ourselves, which should have no extraneous files in them, a lot
> of the objections one might raise go away.
>
> Why don't you go ahead and apply that to HEAD for the time being, even
> if we end up replacing it later?  Might as well start saving developers'
> time immediately.

Done.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Faster install-sh in C
Next
From: Bruce Momjian
Date:
Subject: Re: problem with CR+LF in files in psql \i command