Re: function body error checking issues - Mailing list pgsql-general

From Bruce Momjian
Subject Re: function body error checking issues
Date
Msg-id 200502250503.j1P53wB08744@candle.pha.pa.us
Whole thread Raw
In response to function body error checking issues  (<tony_caduto@amsoftwaredesign.com>)
Responses Re: function body error checking issues  (Neil Conway <neilc@samurai.com>)
List pgsql-general
tony_caduto@amsoftwaredesign.com wrote:
> Bruce,
> here is a example:
> (there is a simple error in the function that does not get caught when running the query in 8.0)
>
> CREATE or REPLACE FUNCTION annual.get_ratio( float8, float8)
> RETURNS pg_catalog.float8 AS
> $BODY$
> DECLARE
> execptioncount_in alias for $1;
> questioncount_in alias for $2;
> ratio_out float8;
>
> BEGIN
>   IF (execptioncount_in >0) AND (questioncount_in >0) THEN
>
>     RATIO_OUT = execptioncount_in / questioncount_in;
>
>   ELSE
>     --this variable is not declared, yet when I run this query no error is raised
>     EXCEPTIONRATIO_OUT = 0;
>   END IF;
> return ratio_out;
> END;
> $BODY$
> LANGUAGE 'plpgsql' VOLATILE

Syntax error reporting has been improved in our code so 8.1 might be
better and catching such errors.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-general by date:

Previous
From: "Jon Asher"
Date:
Subject: Re: Which query is less expensive / faster?
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] A way to let Vacuum warn if FSM settings are low.