Wow, that is significantly different. Thanks.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---------------------------------------------------------------------------
Andrew Dunstan wrote:
>
>
> Andrew Dunstan wrote:
>
> >Bruce Momjian said:
> >
> >
> >>Shame we had to duplicate CopyReadLine() in a sense.
> >>
> >>
> >>
> >>
> >
> >
> >If you can find a clean way to merge them please do - I'll be very grateful.
> > My head started to spin when I tried. In general I dislike having more than
> >2 or 2 levels of logic in a given piece of code.
> >
> >
> >
> >
>
> Previous comment courtesy clumsy fingers and the Department of
> Redundancy Department (of course, I meant 2 or 3).
>
> Anyway, please review this patch for copy.c - it's possibly more to your
> taste. It's less redundant, but I'm not sure it's more clear.
>
> cheers
>
> andrew
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
