Re: pg_autovacuum/Win32 Fixes - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: pg_autovacuum/Win32 Fixes
Date
Msg-id 200501240019.j0O0JA723103@candle.pha.pa.us
Whole thread Raw
In response to Re: pg_autovacuum/Win32 Fixes  ("Dave Page" <dpage@vale-housing.co.uk>)
List pgsql-patches
All your pg_autovacuum patches were applied by Neil.

---------------------------------------------------------------------------

Dave Page wrote:
>
>
> > -----Original Message-----
> > From: Neil Conway [mailto:neilc@samurai.com]
> > Sent: 22 January 2005 10:13
> > To: Dave Page
> > Cc: pgsql-patches@postgresql.org
> > Subject: Re: [PATCHES] pg_autovacuum/Win32 Fixes
> >
> > Dave Page wrote:
> > > Theis patch supercedes *all* my earlier ones from today -
> > apologies for
> > > the noise, clearly I need a beer or 3 and a few nights away from the
> > > laptop.
> >
> > @@ -1166,7 +1166,9 @@
> >           exit(0);
> >   #ifdef WIN32
> >       case 'E':
> > -        args->service_dependencies = optarg;
> > +        ZeroMemory(deps, sizeof(deps));
> > +        snprintf(deps, sizeof(deps) - 2, "%s", optarg);
> > +        args->service_dependencies = (char *)deps;
> >           break;
> >       case 'I':
> >           args->install_as_service++;
> >
> > After googling around I can see what this code is intended to
> > do; in the
> > future a comment might be nice.
>
> Sorry - as you probably noticed it was one of 'those days'.
>
> > Also, why not strncpy()?
>
> No reason, just a hangover from some experimentation I was doing. I've
> no objections if you want to change it.
>
> > Barring any objections I'll apply this patch to REL8_0_STABLE
> > and HEAD
> > on Monday.
>
> Thanks, Dave.
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
>       subscribe-nomail command to majordomo@postgresql.org so that your
>       message can get through to the mailing list cleanly
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: pg_autovacuum/Win32 Fixes
Next
From: Neil Conway
Date:
Subject: LRU